Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👌 IMPROVE: put composer attachment buttons into three dot menu #2226

Merged
merged 2 commits into from
Nov 12, 2019
Merged

👌 IMPROVE: put composer attachment buttons into three dot menu #2226

merged 2 commits into from
Nov 12, 2019

Conversation

violoncelloCH
Copy link
Member

as discussed with @jancborchardt

@violoncelloCH violoncelloCH added 3. to review feature:editor All bugs, features and pull requests about the (HTML) editor labels Nov 9, 2019
@skjnldsv skjnldsv mentioned this pull request Nov 9, 2019
Closed
19 tasks
@violoncelloCH violoncelloCH force-pushed the feature/noissue/attachment-buttons-in-three-dot-menu branch from 35b8f0a to 980f827 Compare November 9, 2019 13:44
@ChristophWurst
Copy link
Member

as discussed with @jancborchardt

For #2222 (comment)?

@violoncelloCH
Copy link
Member Author

as discussed with @jancborchardt

For #2222 (comment)?

no, actually this one is about the composer but #2222 is about the reading/displaying view...
this one is rather for #2220 to further improve the mobile composer view (and in general keep the interface clean)

@violoncelloCH violoncelloCH force-pushed the feature/noissue/attachment-buttons-in-three-dot-menu branch from 980f827 to 3cee04c Compare November 12, 2019 11:50
@violoncelloCH
👌 IMPROVE: put composer attachment buttons into three dot menu
ef103eb 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH force-pushed the feature/noissue/attachment-buttons-in-three-dot-menu branch from 3cee04c to ef103eb Compare November 12, 2019 11:54
@violoncelloCH violoncelloCH mentioned this pull request Nov 12, 2019
Merged
1 task
ChristophWurst
ChristophWurst requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to use a custom event name right away, then you can skip the payload. Also, please run the lint autofix to make the linter happy :)

src/components/Composer.vue Outdated Show resolved Hide resolved
src/components/ComposerAttachments.vue Outdated Show resolved Hide resolved
@violoncelloCH violoncelloCH force-pushed the feature/noissue/attachment-buttons-in-three-dot-menu branch from c9bdd82 to 13635b7 Compare November 12, 2019 13:52
@violoncelloCH
👌 IMPROVE: use local event bus instead of component ref to pass event…
149536a 
… to child component

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH force-pushed the feature/noissue/attachment-buttons-in-three-dot-menu branch from 13635b7 to 149536a Compare November 12, 2019 15:21
@ChristophWurst ChristophWurst merged commit 8d8ae11 into master Nov 12, 2019
@ChristophWurst ChristophWurst deleted the feature/noissue/attachment-buttons-in-three-dot-menu branch November 12, 2019 15:50
@ChristophWurst ChristophWurst added this to the 0.19.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review feature:editor All bugs, features and pull requests about the (HTML) editor
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@violoncelloCH @ChristophWurst @jancborchardt