Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS host verification #2782

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Add TLS host verification #2782

merged 1 commit into from
Mar 23, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 23, 2020 •
edited
Loading

Fixes #308

Follow-ups:

@ChristophWurst ChristophWurst added this to the 1.3.0 milestone Mar 23, 2020
@ChristophWurst ChristophWurst requested a review from rullzer March 23, 2020 13:44
@ChristophWurst ChristophWurst self-assigned this Mar 23, 2020
@ChristophWurst ChristophWurst mentioned this pull request Mar 23, 2020
Merged
rullzer
rullzer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Maybe add it to the readme.
And already create issues to set this on a per account basis?

@ChristophWurst
Turn on TLS peer verification
0cc7f6f 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/tls-peer-verification branch from 1d6e3ff to 0cc7f6f Compare March 23, 2020 14:22
@ChristophWurst ChristophWurst mentioned this pull request Mar 23, 2020
Open
@ChristophWurst
Copy link
Member Author

/backport to stable1.1

@ChristophWurst ChristophWurst merged commit c6ed589 into master Mar 23, 2020
@ChristophWurst ChristophWurst deleted the fix/tls-peer-verification branch March 23, 2020 14:47
@backportbot-nextcloud
Copy link

The backport to stable1.1 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

The backport to stable1.1 failed. Please do this backport manually.

🙄

@ChristophWurst
Copy link
Member Author

At this point I don't care anymore :)

@MorrisJobke
Copy link
Member

Then remove also the label, because I regularly go over them to check for not yet back ported stuff :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

STARTTLS Certificate Check
3 participants
@ChristophWurst @MorrisJobke @rullzer