Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate mail_messages.mailbox_id to an INT #2970

Closed
wants to merge 1 commit into from
Closed

Migrate mail_messages.mailbox_id to an INT #2970

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

Fixes #2963

TODO

  • Basis migrations structure
  • Drop the original unique index on [uid, mailbox_id]
  • Create a new unique index
  • Handle migration errors if possible

@ChristophWurst
Migrate mail_messages.mailbox_id to an INT
87eaca2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst self-assigned this Apr 22, 2020
@ChristophWurst ChristophWurst mentioned this pull request Apr 22, 2020
Open
rullzer
rullzer approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈
Looks sane but didn't test

@ChristophWurst
Copy link
Member Author

This is actually not the one :)

#2796 has the drop and recreate logic

@ChristophWurst ChristophWurst removed their assignment Apr 23, 2020
@ChristophWurst ChristophWurst deleted the fix/message-mailbox-id-int branch April 23, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
0. to triage bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mail_messages.mailbox_id should be an INT
2 participants
@ChristophWurst @rullzer