Add the posibility to move mailboxes #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
force-pushed
the
enhacement/move_mailboxes
branch
from
ba19870 to
b5db39d
Compare
|
To bring this to life
Then it will properly show for all mailboxes :) |
GretaD
force-pushed
the
enhacement/move_mailboxes
branch
5 times, most recently
from
18c14b6 to
9267bc7
Compare
GretaD
force-pushed
the
enhacement/move_mailboxes
branch
2 times, most recently
from
a26d00d to
01e23af
Compare
|
@ChristophWurst should i also rename the movemodal.vue into movemessagemodal.vue and include here or as a separate PR? |
| @@ -77,6 +77,14 @@ export default { | |||
| type: String, | |||
| default: t('mail', 'Choose'), | |||
| }, | |||
| pickedMailbox: { | |||
| type: Object, | |||
| required: false, | |||
There was a problem hiding this comment.
needs a default (as function) https://vuejs.org/v2/guide/components-props.html#Prop-Validation
|
Needs rebase |
Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhacement/move_mailboxes
branch
from
01e23af to
b49b94c
Compare
ChristophWurst
approved these changes
Nov 9, 2020
|
Minor detail I noticed while testing #4045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GretaD gretadoci@gmail.com