Clean up HTML response #4016
Merged
Clean up HTML response #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
force-pushed
the
techdept/clean-up-html-response-constructor
branch
from
ee03ee0 to
b735814
Compare
st3iny
reviewed
Nov 6, 2020
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
techdept/clean-up-html-response-constructor
branch
from
53793f9 to
217bac0
Compare
Fixed. Had to tell Psalm that we use a class that it can't find. |
st3iny
approved these changes
Nov 6, 2020
ChristophWurst
deleted the
techdept/clean-up-html-response-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup for #3904.
I think Psalm won't like that we use an unknown class.suppressed. There currently is no public API for the nonce.