-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move threads not messages in drag-and-drop #5674
Conversation
75f6e1c
to
442f21b
Compare
The issue addressed by this PR is still there today |
I can image this happens when the messages are moved in the local cache but not via IMAP. As soon as a sync is triggered, the threads are rebuilt and messages should show up combined. |
I can reproduce it with submailboxes. So, when i move a thread on a mailbox, the thread is moved as one. When i move it on the submailbox its splited. |
Branch updated |
…ction rather than moveMessage Signed-off-by: Cyrille Bollu <cyr.debian@bollu.be>
bb781fd
to
e6a6866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & works
Currently, the drag-and-drop function moves messages rather than threads.
It results that when you move a thread, drag-and-drop actualy only moves the message corresponding to the selected envelope. This results in some visual glitch: first the envelope is removed from the envelope list resulting in the whole thread disappearing from the envelope list, then the envelope list is refreshed and displays back the thread by showing the envelope of another thread's message, one that hasn't been moved yet.
Moving threads rather than messages in the drag-and-drop function makes sense both from a logical perspective (ie: when the user moves a thread's envelope he actually wants to move the whole corresponding thread and not just the corresponding message) and a ux perspective (ie: avoiding this visual glitch).
This PR implements moving threads rather than messages in drag-and-drop.
<----------- EDIT START ------------>
It seems the limitations previously mentioned hereunder are not real:
1.Mail doesn't navigate after moving a thread => This is true but is already the case today, without this PR
2.After the thread is moved, the messages appear as individual messages, not as a single thread, in the destination mailbox => Cannot reproduce it. Was probably just caused by me forgeting to make dev-setup.
So, for me the PR is ready for merge
<----------- EDIT END ----------->
Some limitations of the PR currently are:
Fixes #8310