Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move threads not messages in drag-and-drop #5674

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

StCyr
Copy link
Collaborator

@StCyr StCyr commented Oct 28, 2021

Currently, the drag-and-drop function moves messages rather than threads.

It results that when you move a thread, drag-and-drop actualy only moves the message corresponding to the selected envelope. This results in some visual glitch: first the envelope is removed from the envelope list resulting in the whole thread disappearing from the envelope list, then the envelope list is refreshed and displays back the thread by showing the envelope of another thread's message, one that hasn't been moved yet.

Moving threads rather than messages in the drag-and-drop function makes sense both from a logical perspective (ie: when the user moves a thread's envelope he actually wants to move the whole corresponding thread and not just the corresponding message) and a ux perspective (ie: avoiding this visual glitch).

This PR implements moving threads rather than messages in drag-and-drop.

<----------- EDIT START ------------>
It seems the limitations previously mentioned hereunder are not real:

1.Mail doesn't navigate after moving a thread => This is true but is already the case today, without this PR
2.After the thread is moved, the messages appear as individual messages, not as a single thread, in the destination mailbox => Cannot reproduce it. Was probably just caused by me forgeting to make dev-setup.

So, for me the PR is ready for merge
<----------- EDIT END ----------->

Some limitations of the PR currently are:

  1. Mail doesn't navigate after moving a thread
  2. After the thread is moved, the messages appear as individual messages, not as a single thread, in the destination mailbox => We probably need to re-compute thread information on the destination mailbox after the move.

Fixes #8310

@StCyr StCyr force-pushed the fix/move-thread-not-message branch from 75f6e1c to 442f21b Compare October 28, 2021 10:28
@StCyr StCyr self-assigned this Oct 28, 2021
@StCyr
Copy link
Collaborator Author

StCyr commented Jan 19, 2022

The issue addressed by this PR is still there today

@StCyr StCyr requested a review from GretaD January 19, 2022 14:41
@ChristophWurst
Copy link
Member

After the thread is moved, the messages appear as individual messages, not as a single thread, in the destination mailbox => Cannot reproduce it. Was probably just caused by me forgeting to make dev-setup

I can image this happens when the messages are moved in the local cache but not via IMAP. As soon as a sync is triggered, the threads are rebuilt and messages should show up combined.

@GretaD
Copy link
Contributor

GretaD commented Jan 28, 2022

After the thread is moved, the messages appear as individual messages, not as a single thread, in the destination mailbox => Cannot reproduce it. Was probably just caused by me forgeting to make dev-setup

I can reproduce it with submailboxes. So, when i move a thread on a mailbox, the thread is moved as one. When i move it on the submailbox its splited.

@ChristophWurst
Copy link
Member

Branch updated

…ction rather than moveMessage

Signed-off-by: Cyrille Bollu <cyr.debian@bollu.be>
@ChristophWurst ChristophWurst force-pushed the fix/move-thread-not-message branch from bb781fd to e6a6866 Compare September 13, 2023 09:59
@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2023
24 tasks
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

@ChristophWurst ChristophWurst merged commit c18a1e4 into main Dec 4, 2023
@ChristophWurst ChristophWurst deleted the fix/move-thread-not-message branch December 4, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging Thread to sidebar folder should move all messages in the thread
3 participants