Fix sending outbox messages of deletd accounts #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the account of a local message has been deleted, we will be unable to locate it. This hard error aborts the outbox flush process and gets all other messages stuck as well. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
/backport to stable1.12 |
|
/backport to stable1.13 |
kesselb
approved these changes
May 31, 2022
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the account of a local message has been deleted, we will be unable to
locate it. This hard error aborts the outbox flush process and gets all
other messages stuck as well.
How to test
Main: outbox flushing stops at this broken message
Here: message is ignored, other messages get sent