Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sender position to be centered with the avatar and timestamps #6689

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Change sender position to be centered with the avatar and timestamps #6689

merged 1 commit into from
Jun 14, 2022
+9 −1

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 8, 2022 •
edited
Loading

before
before-nosubject-notag

after
no subjet no tag
nosubjetc

the last 2 are the same as before, this pr fixes only when theres no subject or tags the sender should be centered.
subject+tag
subject-tag-
tag, no subject
nosubject tag

fixes #6621

@GretaD GretaD requested review from ChristophWurst and st3iny June 8, 2022 11:23
@GretaD GretaD self-assigned this Jun 8, 2022
@ChristophWurst
Copy link
Member

  1. I think that the avatar and sender should be on one line if there is no changing subject.
  2. If the subject changes (and is shown) or there are tags assigned to a message, I would not move the sender down anymore.

In other words, I see the sender/subject/tags as one block. and that block should be aligned with the avatar. Does that make sense?

@GretaD
Copy link
Contributor Author

GretaD commented Jun 8, 2022

yeah, sounds good, also i think this is not a bug, its the same design as envelope list, we just removed the subject for threads and didn't change the position.

@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 14, 2022 •
edited
Loading

could you please add before/after screenshots of various test cases?

ChristophWurst
ChristophWurst approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter should complain about the indentation

@ChristophWurst
Copy link
Member

/backport to stable1.13

@ChristophWurst
Copy link
Member

/backport to stable1.12

@GretaD
Make sender to be centered with the avatar and timestamps
a1fd9c3 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the fix/receipient-center branch from 280674b to a1fd9c3 Compare June 14, 2022 11:48
@ChristophWurst ChristophWurst enabled auto-merge June 14, 2022 11:51
@ChristophWurst ChristophWurst merged commit 704881e into main Jun 14, 2022
@ChristophWurst ChristophWurst deleted the fix/receipient-center branch June 14, 2022 11:55
This was referenced Jun 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@GretaD GretaD

Labels
4. to release bug design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sender of thread message not vertically centered
2 participants
@GretaD @ChristophWurst