Collapse quoted text in HTML message #6770
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Sazanov <m@sazanof.ru>
I think that will always be a bit of catch-up. I suggest we abstract the parsing/detection a bit and put it into a testable function. That function can be unit tested against a few common formattings of popular email clients. |
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| .quote { |
There was a problem hiding this comment.
nit: restructure to use BEM https://scalablecss.com/bem-blocks-within-blocks/
| import HtmlBlockQuoteItem from './HtmlBlockQuoteItem' | ||
| import CommentQuote from 'vue-material-design-icons/CommentQuote' | ||
|
|
||
| const REGEXP_EMAIL = /([!#-'*+/-9=?A-Z^-~-]+(\.[!#-'*+/-9=?A-Z^-~-]+)*|(\[\]!#-[^-~ \t]|(\\[\t -~]))+")@([!#-'*+/-9=?A-Z^-~-]+(\.[!#-'*+/-9=?A-Z^-~-]+)*|\[[\t -Z^-~]*])/ |
There was a problem hiding this comment.
this is the part I'd like to see abstracted and tested 😆
|
friendly ping @sazanof |
|
4 packets received, 0 packets lost. upd (oh, I see =)) |
|
Well, there will be something to do =) |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Based on #3640
In fact, I have encountered several (many =)) problems. It would be great if you could tell me something.
A little preface: perhaps this is not the most successful implementation, but I have not found another way yet.
Problems:
OC not found". I need to connect the translation innew Vue()instance and upload avatars functions. And when importing l10n or fetchAvatarUrlMemoized, they just don't work. Tell me how to connect them correctly?core/cssgives an error, Tell me how I can include these styles correctly.I would like to hear opinions about the implementation, because although it is not urgent, it is a very pleasant improvement. I will be grateful for any help and glad for any advice!
Thanks!
Well, where to without screenshots:
Signed-off-by: Mikhail Sazanov m@sazanof.ru