Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imip processing in the background #6812

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add imip processing in the background #6812

merged 1 commit into from
Sep 9, 2022

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jun 30, 2022 •
edited
Loading

Fixes #6802

Questions:

what happens when I have a very large mailbox where I never trigger the preview for messages below the fold?

@miaulalala miaulalala added enhancement 2. developing feature:imip For all tasks related to the iMIP functionality labels Jun 30, 2022
@miaulalala miaulalala self-assigned this Jun 30, 2022
ChristophWurst
ChristophWurst reviewed Jun 30, 2022
View reviewed changes
lib/Db/Message.php Outdated Show resolved Hide resolved
lib/Db/Message.php Outdated Show resolved Hide resolved
lib/Db/MessageMapper.php Outdated Show resolved Hide resolved
lib/Migration/Version1140Date20220630113356.php Outdated Show resolved Hide resolved
lib/Migration/Version1140Date20220630113356.php Outdated Show resolved Hide resolved
lib/Migration/Version1140Date20220630113356.php Outdated Show resolved Hide resolved
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from b43b7fe to f113610 Compare July 19, 2022 12:01
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 1bfa02a to 649689e Compare July 29, 2022 14:18
@miaulalala

This comment was marked as off-topic.

Sign in to view
@kevincox

This comment was marked as off-topic.

Sign in to view
@miaulalala

This comment was marked as off-topic.

Sign in to view
@kevincox

This comment was marked as off-topic.

Sign in to view
@miaulalala

This comment was marked as off-topic.

Sign in to view
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 649689e to fa7ec4e Compare August 11, 2022 10:44
@miaulalala miaulalala marked this pull request as ready for review August 11, 2022 12:14
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from fa7ec4e to 768221d Compare August 11, 2022 12:24
@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 11, 2022 •
edited
Loading

  • add another BG job that processes all messages until 2 weeks into the past for structure Analysis. (should make mail app faster)

@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from b136fc7 to 005f30d Compare August 16, 2022 16:59
kesselb
kesselb reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to bump the version number to install the background job.

tests/Unit/Service/PreprocessingServiceTest.php Outdated Show resolved Hide resolved
lib/Db/MessageMapper.php Outdated Show resolved Hide resolved
lib/IMAP/MessageMapper.php Show resolved Hide resolved
lib/IMAP/MessageMapper.php Show resolved Hide resolved
lib/Service/IMipService.php Outdated Show resolved Hide resolved
lib/Db/MessageMapper.php Outdated Show resolved Hide resolved
@miaulalala miaulalala mentioned this pull request Aug 16, 2022
Closed
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from bc259c4 to 62463a8 Compare August 17, 2022 11:09
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 62463a8 to 33842a8 Compare August 18, 2022 09:26
@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 22, 2022 •
edited
Loading

just waiting for server PR now

@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 49ed373 to cc930ce Compare August 22, 2022 20:14
@miaulalala
Copy link
Contributor Author

miaulalala commented Sep 6, 2022 •
edited
Loading

stable22, 23 and 24 test failing is not surprising as this isn't backported

@ChristophWurst ChristophWurst added this to the v2.0.0 milestone Sep 6, 2022
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from cc930ce to 30b183f Compare September 7, 2022 22:53
@miaulalala
Copy link
Contributor Author

@ChristophWurst I added a check on the IManager to see if the method handleImipReply exists so we can avoid the whole test suite exploding for the next however many releases.

Shamelessly stolen from https://github.com/nextcloud/calendar/blob/main/tests/php/unit/Service/Appointments/BookingServiceTest.php

@ChristophWurst ChristophWurst mentioned this pull request Sep 8, 2022
Closed
6 tasks
ChristophWurst
ChristophWurst reviewed Sep 8, 2022
View reviewed changes
lib/BackgroundJob/PreviewEnhancementProcessingJob.php Outdated Show resolved Hide resolved
lib/Db/MessageMapper.php Outdated Show resolved Hide resolved
lib/Migration/Version1140Date20220630113356.php Outdated Show resolved Hide resolved
lib/Service/MailManager.php Outdated Show resolved Hide resolved
lib/Service/PreprocessingService.php Outdated Show resolved Hide resolved
lib/Service/PreprocessingService.php Outdated Show resolved Hide resolved
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 30b183f to 673fdf3 Compare September 8, 2022 13:18
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch 2 times, most recently from e2197b8 to 35cf81a Compare September 8, 2022 13:42
@ChristophWurst
Copy link
Member

linter

@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from dca353a to 2a72eca Compare September 8, 2022 15:43
ChristophWurst
ChristophWurst approved these changes Sep 9, 2022
View reviewed changes
lib/BackgroundJob/IMipMessageJob.php Outdated Show resolved Hide resolved
lib/BackgroundJob/IMipMessageJob.php Outdated Show resolved Hide resolved
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 8f5db2f to 0dcfb5f Compare September 9, 2022 10:59
@miaulalala
Add imip processing
2dcf8b9 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enh/process-imip-in-background branch from 0dcfb5f to 2dcf8b9 Compare September 9, 2022 11:16
@ChristophWurst ChristophWurst merged commit 5670311 into main Sep 9, 2022
@ChristophWurst ChristophWurst deleted the enh/process-imip-in-background branch September 9, 2022 11:40
@ChristophWurst ChristophWurst mentioned this pull request Jul 6, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

@miaulalala miaulalala

Labels
3. to review enhancement feature:imip For all tasks related to the iMIP functionality
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Process iMip responses
4 participants
@miaulalala @kevincox @ChristophWurst @kesselb