Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XOAUTH2 #6819

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add support for XOAUTH2 #6819

merged 1 commit into from
Jul 1, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 1, 2022

This is the foundation for #6454 and #6591.

You can now add an account via CLI if you know the OAUTH access token. Horde will successfully authenticate using the token.

The process of acquiring the token will be specific to each service. We will have to implement those parts for Google and Microsoft.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not need to save the auth method in the DB?

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst ChristophWurst marked this pull request as ready for review July 1, 2022 13:55
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is just for occ at the moment, right?

@ChristophWurst
Copy link
Member Author

LGTM! This is just for occ at the moment, right?

Yes! #6819 (comment)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants