Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate icons to material design icons #6995

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 12, 2022

Ref nextcloud/groupware#38
To do

there are some bugs because of nc/vue update but not connected to this pr, those bugs can be found here: #7071

test carefully composer(send email, drafts and stuff) and loading envelopes

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered multiple issues while testing.

NOTE: Some of those issues might be on main too or caused by the nc-vue upgrade to 6.0.0.

1. Send later ActionButtons are jumping on hover

This is most likely caused by the nc-vue upgrade.

Peek.2022-08-16.15-20.webm

2. Attachment modal can't be interacted with and closed

(I'm spamming left click as I hover various elements in the video.)

Peek.2022-08-16.15-29.webm

The close button is not working which resulted in me being stuck and having to force reload the page.

ksnip_20220816-152733

3. Account settings modal can't be closed via the X

However, it can be closed by clicking outside.

ksnip_20220816-152501

4. The account creation modal is missing its form

ksnip_20220816-153114

@ChristophWurst ChristophWurst changed the title Migrate icons to material design icons Migrate icons to material design icons / Bump @nextcloud/vue to v6 Aug 17, 2022
@GretaD GretaD force-pushed the change/icon-loading-vue6 branch from c147cd2 to c4defb2 Compare August 23, 2022 12:11
@GretaD GretaD mentioned this pull request Aug 23, 2022
@GretaD
Copy link
Contributor Author

GretaD commented Aug 23, 2022

the problems Richard found are fixed. This pr #7060 is needed to move on

@GretaD GretaD removed the blocked label Aug 23, 2022
@GretaD GretaD force-pushed the change/icon-loading-vue6 branch from c4defb2 to 8b4d088 Compare August 23, 2022 18:00
@GretaD GretaD marked this pull request as ready for review August 23, 2022 18:05
@ChristophWurst ChristophWurst changed the title Migrate icons to material design icons / Bump @nextcloud/vue to v6 Migrate icons to material design icons Aug 23, 2022
@GretaD GretaD force-pushed the change/icon-loading-vue6 branch 3 times, most recently from 253f93b to 68c7c4b Compare August 24, 2022 09:10
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD merged commit 4b6f1dd into main Aug 26, 2022
@GretaD GretaD deleted the change/icon-loading-vue6 branch August 26, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants