Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nextcloud/vue to v7.0.0-beta.0 #7129

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Bump @nextcloud/vue to v7.0.0-beta.0 #7129

merged 1 commit into from
Sep 2, 2022

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 1, 2022 •
edited
Loading

  • add appcontent on setup.vue

@ChristophWurst ChristophWurst changed the title Bump v7.0.0-beta.0 Bump @nextcloud/vue to v7.0.0-beta.0 Sep 1, 2022
@ChristophWurst ChristophWurst added 2. developing dependencies javascript Pull requests that update Javascript code labels Sep 1, 2022
@ChristophWurst ChristophWurst added this to the v1.14.0 milestone Sep 1, 2022
@ChristophWurst
Copy link
Member

Make sure you are on the latest server master because v7 requires nextcloud-libraries/nextcloud-vue#3091. That PR was just merged 2h ago.

@ChristophWurst
Copy link
Member

Judging by your header bar you are on an old master or another branch. The design should look a lot different.

@GretaD GretaD force-pushed the bump/v7.0.0-beta.0 branch 2 times, most recently from 1d98302 to 802e248 Compare September 1, 2022 16:03
@GretaD GretaD marked this pull request as ready for review September 1, 2022 16:04
@GretaD GretaD force-pushed the bump/v7.0.0-beta.0 branch 3 times, most recently from 6f1a084 to 2e970e9 Compare September 1, 2022 16:08
@GretaD
Bump v7.0.0-beta.0
7812bda 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the bump/v7.0.0-beta.0 branch from 2e970e9 to 7812bda Compare September 1, 2022 16:10
@GretaD
Copy link
Contributor Author

GretaD commented Sep 1, 2022

i cannot reproduce this: nextcloud-libraries/nextcloud-vue#3091 (comment)

all looks good on header

@ChristophWurst
Copy link
Member

i cannot reproduce this: nextcloud/nextcloud-vue#3091 (comment)

yep, I could also not tell what's supposed to be broken

ChristophWurst
ChristophWurst requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to drop nextcloud 24 and older. let's do that carefully

@GretaD GretaD merged commit 451fd46 into main Sep 2, 2022
@GretaD GretaD deleted the bump/v7.0.0-beta.0 branch September 2, 2022 14:17
@ChristophWurst ChristophWurst modified the milestones: v1.14.0, v2.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@GretaD GretaD

Labels
3. to review dependencies javascript Pull requests that update Javascript code
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GretaD @ChristophWurst