Add ckeditor5-html-embed plugin in TextEditor.vue #7298
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
|
@ChristophWurst |
package.json
Outdated
| @@ -34,6 +34,7 @@ | |||
| "@ckeditor/ckeditor5-theme-lark": "~35.1.0", | |||
| "@ckeditor/ckeditor5-upload": "^35.1.0", | |||
| "@ckeditor/ckeditor5-vue2": "^3.0.1", | |||
| "@ckeditor/ckeditor5-html-embed": "~35.1.0", | |||
There was a problem hiding this comment.
the corresponding package-lock.json change is missing here
There was a problem hiding this comment.
@ChristophWurst
I've added the missing entries in the package-lock.json. Sadly i used the wrong account to push this into my repo. I do hope this is not a problem.
There was a problem hiding this comment.
@ChristophWurst
Hey there, is everything now to your liking and correct?
There was a problem hiding this comment.
I believe the only thing left to fix is indentation. Look at the file you changed and existing lines before/after. Use the same indentation style.
There was a problem hiding this comment.
@ChristophWurst
I fixed what looked weird to me.
I dont see anything else, if you see something please let me know.
|
#7427 (comment) this looks very strange in the UI to be honest. |
I added the ckeditor5-html-embed plugin, so that it is possible to use it in the signature editor.
It enables the use of html signatures.
I made this change, because working with tables #7282 to create a copy of our company signature doesnt work.