Add lean sync for servers without CONDSTORE #7375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
rullzer
reviewed
Oct 5, 2022
| ->where( | ||
| $query->expr()->eq('mailbox_id', $query->createNamedParameter($mailbox->getId(), IQueryBuilder::PARAM_INT), IQueryBuilder::PARAM_INT), | ||
| $query->expr()->eq($col, $query->createNamedParameter(!$set, IQueryBuilder::PARAM_BOOL), IQueryBuilder::PARAM_BOOL), | ||
| $query->expr()->in('uid', $query->createParameter('uids'), IQueryBuilder::PARAM_INT_ARRAY), |
There was a problem hiding this comment.
I'm not sure if possible with all your fancy pancy supported databases
but an index like
('mailbox_id', 'uid') INCLUDING (flag1, flag2, flag3, flag4, flag5, flag6) would allow the filtering to happen mainly on the index level. Without going to the actual data.
24 tasks
|
Superseded by #9235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6341
This updates flags in 20+ queries. Bigger mailboxes require more queries. But still, if you have 150k messages the sync ran 150k updates before, now it runs 20k. If we say that only read/unread and important flags are relevant we can cut it to 600 queries.
It aint much, but it it's an honest optimization.
Todo