fix(imap): Chunk UIDs by string length #8367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMAP sync requires an IMAP FETCH command that fetches specific messages. If the full mailbox has to be sync'ed, that can be a long list of UIDs. The synchronizer had already broken UIDs into chunks by a maximum chunk size. Yet the chunk size does not correlate with the resulting IMAP FETCH command length. An advanced chunk function calculates the UID range string and decreases the chunk size until the UIDs produce a string that fits the given byte size. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
3. to review
nextcloud-gmbh
miaulalala
approved these changes
Apr 12, 2023
|
there is also no significant performance regression |
|
/backport to stable3.1 |
|
/backport to stable2.2 |
This was referenced Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAP sync requires an IMAP FETCH command that fetches specific messages. If the full mailbox has to be sync'ed, that can be a long list of UIDs.
The synchronizer had already broken UIDs into chunks by a maximum chunk size. Yet the chunk size does not correlate with the resulting IMAP FETCH command length.
An advanced chunk function calculates the UID range string and decreases the chunk size until the UIDs produce a string that fits the given byte size.
Fixes #6038