Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure subquery in findNewIds never returns NULL #8590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure subquery in findNewIds never returns NULL #8590

wants to merge 3 commits into from

Conversation

IchbinkeinReh
Copy link
Collaborator

@IchbinkeinReh IchbinkeinReh commented Jul 2, 2023 •
edited by ChristophWurst
Loading

Fixes #4479

@ChristophWurst ChristophWurst changed the title fix #4479 by ensuring subquery in findNewIds never returns NULL Ensure subquery in findNewIds never returns NULL Sep 13, 2023
@IchbinkeinReh @ChristophWurst
fix nextcloud#4479 by ensuring subquery in findNewIds never returns NULL
ed2d0da 
Signed-off-by: Patrick Bender <patrick@bender-it-services.de>
@ChristophWurst
Copy link
Member

Change makes sense yet I'm unsure if it fixes #4479 entirely.

To verify all our supported databases understand the query we should add an integration test for \OCA\Mail\Db\MessageMapper::findNewIds

@ChristophWurst
fixup! fix nextcloud#4479 by ensuring subquery in findNewIds never re…
e8b34b0 
…turns NULL

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
ChristophWurst reviewed Sep 13, 2023
View reviewed changes
tests/Integration/Db/MessageMapperTest.php

$found = $this->mapper->findNewIds($mailbox, [$id + 1]);

self::assertCount(1, $found);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails without COALESCE 👍

@ChristophWurst
fixup! fix nextcloud#4479 by ensuring subquery in findNewIds never re…
045e0bb 
…turns NULL

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member

On a second look I'm skeptical about \OCA\Mail\Db\MessageMapper::findNewIds. The method is supposed to return all messages newer than the messages identified with the passed ids. Oracle doesn't like big IN clauses, so we chunk the ids array and run the query at least once. The semantics are that we'll get all messages newer than the oldest message of each chunk.

👀 @kesselb

@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MailboxDoesNotSupportModSequencesException problem with mails
2 participants
@IchbinkeinReh @ChristophWurst