Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AccountForm.vue so Reconnect button works for Microsoft accounts #8644

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update AccountForm.vue so Reconnect button works for Microsoft accounts #8644

merged 1 commit into from
Jul 2, 2024

Conversation

ccci-code
Copy link
Contributor

@ccci-code ccci-code commented Jul 21, 2023 •
edited by ChristophWurst
Loading

Also replace Google with Microsoft for button labels and feedback

Fixes #8641

@welcome
Copy link

welcome bot commented Jul 21, 2023

Thanks for opening your first pull request in this repository! ✌️

@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2023
Closed
24 tasks
@ChristophWurst ChristophWurst force-pushed the patch-1 branch 2 times, most recently from be24676 to fc4a47e Compare February 23, 2024 15:41
@ChristophWurst ChristophWurst force-pushed the patch-1 branch 2 times, most recently from 2f36539 to a1c4c74 Compare February 27, 2024 19:06
ChristophWurst
ChristophWurst approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax fixed

@ccci-code @ChristophWurst
Update AccountForm.vue so Reconnect button works for Microsoft accounts
e4b4102 
Also replace Google with Microsoft for button labels and feedback

Signed-off-by: ccci-code <69860674+ccci-code@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ChristophWurst ChristophWurst disabled auto-merge July 2, 2024 07:46
@ChristophWurst ChristophWurst merged commit b194763 into nextcloud:main Jul 2, 2024
29 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
4. to release bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconnect Google account button fails for Microsoft accounts
2 participants
@ccci-code @ChristophWurst