-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: add backend check for download permission for cloud attachements #9592
Conversation
3985509
to
0b875b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend side works. When sending the mail a warning is logged, the attachment is still shown in the frontend (composer) but not sent.
I wonder why the frontend let's me pick a file without download permissions. Shouldn't the file picker filter incoming shares without download permissions?
they're supposed to be filtered out, it's a regression, I'm investigating |
0b875b4
to
6648bce
Compare
I'm still investigating the frontend regression, my doubt i that it's a filepicker regression, since share-attributes are not shown anymore, I'm checking with other colleagues |
Sounds good. I'd also say that we can move forward with this PR and look at the frontend separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
/backport to stable3.7 |
/backport to stable3.6 |
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
0e71d88
to
f0e072e
Compare
/backport to 2.9 Update : typo :'( |
The backport to # Switch to the target branch and update it
git checkout 2.9
git pull origin 2.9
# Create the new backport branch
git checkout -b backport/9592/2.9
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f0e072ed
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9592/2.9 Error: Failed to clone repository: Failed to checkout branches: error: pathspec '2.9' did not match any file(s) known to git Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable2.2 |
/backport to stable1.15 |
For now it silently Fails on draft/outbox save/update