Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark junk mail automatically as read and unimportant #9820

Merged

Conversation

germelmann
Copy link
Member

fixes #9710

@germelmann germelmann requested a review from GretaD July 9, 2024 07:55
@@ -727,6 +727,15 @@ export default {
async onToggleJunk() {
const removeEnvelope = await this.$store.dispatch('moveEnvelopeToJunk', this.data)

if (this.isImportant) {
this.$store.dispatch('toggleEnvelopeImportant', this.data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.$store.dispatch('toggleEnvelopeImportant', this.data)
await this.$store.dispatch('toggleEnvelopeImportant', this.data)

}

if (!this.data.flags.seen) {
console.log('toggleEnvelopeSeen')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line please


if (!this.data.flags.seen) {
console.log('toggleEnvelopeSeen')
this.$store.dispatch('toggleEnvelopeSeen', { envelope: this.data })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.$store.dispatch('toggleEnvelopeSeen', { envelope: this.data })
await this.$store.dispatch('toggleEnvelopeSeen', { envelope: this.data })

Signed-off-by: Peter-J. G. <peter.germelmann@gmail.com>
@germelmann germelmann force-pushed the feat/9710/mark-junk-automatically-unimportant-and-unread branch from 0e520f7 to d9c20c5 Compare July 9, 2024 08:33
@germelmann germelmann requested a review from ChristophWurst July 9, 2024 08:34
@germelmann germelmann merged commit 027a910 into main Jul 9, 2024
28 checks passed
@germelmann germelmann deleted the feat/9710/mark-junk-automatically-unimportant-and-unread branch July 9, 2024 08:52
@sgofferj
Copy link

Fantastic! Thank you for your work!

@germelmann germelmann self-assigned this Jul 10, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically mark mail as read and remove important tag when manually marked as junk
3 participants