feat(ocs): add OCS extractor and workflow #9832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
from
935052b to
0eea010
Compare
miaulalala
changed the title
miaulalala
added
github_actions
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
2 times, most recently
from
ffdbd82 to
402f4ef
Compare
provokateurin
approved these changes
Jul 23, 2024
ChristophWurst
requested changes
Jul 25, 2024
There was a problem hiding this comment.
- Commit check in the workflow is not necessary. We don't want to vendor the openapi output in git.
- Adjust to generate the opnapi files before packaging.
Lines 5 to 7 in b9bdff0
- The new vendor bin should be monitored by renovate bot. Add it to https://github.com/nextcloud/mail/blob/b9bdff0b88baf3b8f211059a07a129b4fd3ca8cc/renovate.json.
|
The check is necessary to detect errors, even if you don't want to commit the result. Otherwise you'll only learn of the problems once you try to do a release... |
|
@provokateurin I mean "Check openapi*.json and typescript changes" to go. "Regenerate OpenAPI" has to stay of course. |
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
from
402f4ef to
b6c6517
Compare
There was a problem hiding this comment.
The new vendor bin should be monitored by renovate bot. Add it to https://github.com/nextcloud/mail/blob/b9bdff0b88baf3b8f211059a07a129b4fd3ca8cc/renovate.json. not necessary
ChristophWurst
approved these changes
Aug 6, 2024
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
from
ec0f3ea to
bf54fb1
Compare
|
Squash harder |
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
from
bf54fb1 to
bebec3e
Compare
|
ChristophWurst
approved these changes
Aug 6, 2024
ChristophWurst
requested changes
Aug 7, 2024
ChristophWurst
approved these changes
Aug 7, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
enh/add-openapi-extractor-and-workflow
branch
from
e410f33 to
e854dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #9749 and #9672