Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_framework): Respect the configured apps order #2067

Merged
merged 1 commit into from
May 24, 2024

Conversation

provokateurin
Copy link
Member

Closes #814
Unfortunately I can not add tests in this PR because the whole bloc is not tested yet. Just verifying manually that this works should be enough though.

@provokateurin provokateurin requested a review from Leptopoda May 22, 2024 10:51
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 29.84%. Comparing base (2a2eeee) to head (536e3bd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2067      +/-   ##
==========================================
- Coverage   29.84%   29.84%   -0.01%     
==========================================
  Files         254      254              
  Lines       84774    84777       +3     
==========================================
  Hits        25302    25302              
- Misses      59472    59475       +3     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 2a2eeee
dynamite 31.00% <ø> (ø) Carriedforward from 2a2eeee
dynamite_end_to_end_test 61.47% <ø> (ø) Carriedforward from 2a2eeee
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 2a2eeee
neon_dashboard 92.56% <ø> (ø)
neon_framework 39.90% <0.00%> (-0.04%) ⬇️
neon_talk 96.77% <ø> (ø)
nextcloud 26.48% <ø> (ø) Carriedforward from 2a2eeee
sort_box 90.90% <ø> (ø) Carriedforward from 2a2eeee

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/neon_framework/lib/src/blocs/apps.dart 0.00% <0.00%> (ø)

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/neon_framework/respect-apps-order branch from 9f18e86 to 536e3bd Compare May 22, 2024 14:04
@provokateurin provokateurin requested a review from Leptopoda May 22, 2024 14:05
@provokateurin
Copy link
Member Author

Ok forget my comments, the order is actually sometimes and int and sometimes a string (but int encoded as string). I'll try to fix this upstream in nextcloud/server#45455.

@provokateurin provokateurin merged commit 5d0ca76 into main May 24, 2024
8 of 10 checks passed
@provokateurin provokateurin deleted the feat/neon_framework/respect-apps-order branch May 24, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order apps according to the server order
2 participants