Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamite: Correctly await responses where necessary #463

Merged
merged 1 commit into from
Jul 13, 2023
Merged

dynamite: Correctly await responses where necessary #463

merged 1 commit into from
Jul 13, 2023

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin requested a review from Leptopoda July 13, 2023 14:57
@provokateurin provokateurin mentioned this pull request Jul 13, 2023
Merged
@Leptopoda
Copy link
Member

Why exactly is this needed?

@provokateurin
Copy link
Member Author

The combination of text/plain with headers was broken because an await that should not be there was emitted (or there was a missing await, i can't recall right now).

Leptopoda
Leptopoda approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow have the feeling that this can be done cleaner 🤔

But let's get it merged so we can move on with more important stuff; dynamite isn't run in production after all :)

@provokateurin provokateurin merged commit 1fda209 into main Jul 13, 2023
@provokateurin provokateurin deleted the fix/correctly-await-responses branch July 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @Leptopoda