fix (hopefully) weird app crash on android 8

nextcloud · Jan 28, 2018 · 6bf2b45 · 6bf2b45
1 parent 7aea76c
commit 6bf2b45
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java
@@ -68,12 +68,13 @@ public static int getResourceIdForRightDefaultFeedIcon(Context context)
 			return R.drawable.default_feed_icon_dark;
 	}
 
-	public void PreCacheFavIcon(final Feed feed) {
+	public void PreCacheFavIcon(final Feed feed) throws IllegalStateException {
         if(feed.getFaviconUrl() == null) {
             Log.v(TAG, "No favicon for "+feed.getFeedTitle());
             return;
         }
 
+        Log.v(TAG, "Loading image: " + feed.getFaviconUrl());
         ImageLoader.getInstance().loadImage(feed.getFaviconUrl(), displayImageOptions, new ImageLoadingListener() {
             @Override
             public void onLoadingStarted(String imageUri, View view) {

diff --git a/...ndroid-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java b/...ndroid-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java
@@ -130,7 +130,11 @@ protected void onHandleWork(@NonNull Intent intent) {
             List<Feed> feedList = dbConn.getListOfFeeds();
             FavIconHandler favIconHandler = new FavIconHandler(this);
             for(Feed feed : feedList) {
-                favIconHandler.PreCacheFavIcon(feed);
+                try {
+                    favIconHandler.PreCacheFavIcon(feed);
+                } catch(IllegalStateException ex) {
+                    Log.e(TAG, ex.getMessage());
+                }
             }
         } else if(downloadMode.equals(DownloadMode.FAVICONS_AND_PICTURES) || downloadMode.equals(DownloadMode.PICTURES_ONLY)) {
             long lastId = intent.getLongExtra(LAST_ITEM_ID, 0);