Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud News: When adding subscription folders are sorted randomly #2090

Closed
3 tasks done
mercury1337 opened this issue Feb 7, 2023 · 3 comments · Fixed by #2205
Closed
3 tasks done

Nextcloud News: When adding subscription folders are sorted randomly #2090

mercury1337 opened this issue Feb 7, 2023 · 3 comments · Fixed by #2205
Labels
enhancement frontend impact Javascript/Frontend code

Comments

@mercury1337
Copy link

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

When adding a new subscription you can select a folder in the drop-down. The list of folders seems to be randomly sorted. (see screenshot where I would expect folders to be sorted by the numbers)

nextcloud news subscribe folder sort

Steps to Reproduce

Explain what you did to encounter the issue

  1. Click "subscribe
  2. Add address of a feed
  3. In the dropdown for the folders the folders are not sorted by alphabet (see screenshot)

System Information

  • News app version:20.0.1
  • Nextcloud version:25.0.3
  • Cron type: System cron
  • PHP version: Version: 8.1.2
  • Database and version: mysql 8.0.32
  • Browser and version: Firefox 109.0.1 (Linux) or Version 109.0.5414.120 (Official Build, ungoogled-chromium) (64-bit)
  • OS and version: Ubuntu 22.04.1 LTS
Contents of nextcloud/data/nextcloud.log
Could not find anything related to that topic in the logs.
Contents of Browser Error Console Read http://ggnome.com/wiki/Using_The_Browser_Error_Console if you are unsure what to put here
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). [utils.js:42:9](moz-extension://4c8cb9e0-e5f7-48c6-a9b4-88be8b0e5d02/js/contentscripts/utils.js)
Proxying an event bus of version 2.1.1 with 1.3.0 [index.es.js:2337:14](webpack:///nextcloud/node_modules/@nextcloud/auth/node_modules/@nextcloud/event-bus/dist/index.es.js)
JQMIGRATE: Migrate is installed, version 3.4.0 [jquery-migrate.min.js:2:698](webpack:///nextcloud/node_modules/jquery-migrate/dist/jquery-migrate.min.js)
Proxying an event bus of version 2.1.1 with 1.3.0 [index.es.js:2337:14](webpack:///nextcloud/node_modules/@nextcloud/auth/node_modules/@nextcloud/event-bus/dist/index.es.js)
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 2 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
Proxying an event bus of version 2.1.1 with 3.0.2 [ProxyBus.ts:16:20](webpack:///lib/ProxyBus.ts)
Proxying an event bus of version 2.1.1 with 3.0.2 [ProxyBus.ts:16:20](webpack:///lib/ProxyBus.ts)
Proxying an event bus of version 2.1.1 with 1.3.0 [index.es.js:2337:14](webpack:///notifications/node_modules/@nextcloud/notify_push/node_modules/@nextcloud/auth/node_modules/@nextcloud/event-bus/dist/index.es.js)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
Registering notifications container as a menu [NotificationsApp.vue:220](webpack:///notifications/src/NotificationsApp.vue)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 2 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
Notifications permissions granted [NotificationsApp.vue:461](webpack:///notifications/src/NotificationsApp.vue)
Polling interval updated to 30000 [NotificationsApp.vue:421](webpack:///notifications/src/NotificationsApp.vue)
Started background fetcher as session_keepalive is enabled [NotificationsApp.vue:283](webpack:///notifications/src/NotificationsApp.vue)
Proxying an event bus of version 2.1.1 with 1.3.0 [index.es.js:2337:14](webpack:///nextcloud/node_modules/@nextcloud/auth/node_modules/@nextcloud/event-bus/dist/index.es.js)
Proxying an event bus of version 2.1.1 with 3.0.0 [index.js:19:12](webpack:///nextcloud/node_modules/@nextcloud/vue/node_modules/@nextcloud/event-bus/dist/index.js)
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 3 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 3 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”). [angular.min.js:205](https://lucius.schachl.name/nextcloud/apps/news/js/build/angular.min.js)
session heartbeat polling started [session-heartbeat.js:103:9](webpack:///nextcloud/core/src/session-heartbeat.js)
[DEBUG] unified-search: Unified Search initialized with the following providers 
Object { 0: {…}, 1: {…}, 2: {…}, 3: {…}, 4: {…}, 5: {…}, 6: {…}, 7: {…}, 8: {…}, 9: {…}, … }
[ConsoleLogger.js:52:10](webpack:///nextcloud/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
Got notification data [NotificationsApp.vue:384](webpack:///notifications/src/NotificationsApp.vue)
Polling interval updated to 30000 [NotificationsApp.vue:421](webpack:///notifications/src/NotificationsApp.vue)
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 6 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 16 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 104 [globals.js:60:15](webpack:///nextcloud/core/src/globals.js)
No new notification data received [NotificationsApp.vue:389](webpack:///notifications/src/NotificationsApp.vue)
Polling interval updated to 30000 [NotificationsApp.vue:421](webpack:///notifications/src/NotificationsApp.vue)
No new notification data received [NotificationsApp.vue:389](webpack:///notifications/src/NotificationsApp.vue)
Polling interval updated to 30000 [NotificationsApp.vue:421](webpack:///notifications/src/NotificationsApp.vue)

@mercury1337 mercury1337 added the bug label Feb 7, 2023
@Grotax Grotax added enhancement frontend impact Javascript/Frontend code and removed bug labels Feb 7, 2023
@Grotax
Copy link
Member

Grotax commented Feb 7, 2023

Certainly a strange behaviour.

There is not much movement on the frontend and there is no regular developer. If you can create a PR to fix it yourself.

@anoymouserver
Copy link
Contributor

Apparently they are sorted by their creation order (= database id) .. I suppose it ends in this query, after some abstraction levels in the PHP controller and JS resources.

$builder->select('*')
->from($this->tableName)
->where('user_id = :user_id')
->andWhere('deleted_at = 0')
->setParameter('user_id', $userId);

@Grotax
Copy link
Member

Grotax commented Feb 7, 2023

Yea probably, the frontend or also apps need to handle stuff like that-

Grotax added a commit that referenced this issue Apr 20, 2023
Fixed
- Fix audio player floating when scrolling in NC25+ (#2142)
- Fix sorting of folder names in select when adding subscription (#2090)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this issue Apr 23, 2023
Fixed
- Fix audio player floating when scrolling in NC25+ (#2142)
- Fix sorting of folder names in select when adding subscription (#2090)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement frontend impact Javascript/Frontend code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants