Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue in NC 26 with expanded articles #2192

Closed
ManuelSailer opened this issue Apr 11, 2023 · 0 comments · Fixed by #2196
Closed

Display issue in NC 26 with expanded articles #2192

ManuelSailer opened this issue Apr 11, 2023 · 0 comments · Fixed by #2196

Comments

@ManuelSailer
Copy link
Contributor

ManuelSailer commented Apr 11, 2023

Nextcloud version: 26.0.0
News app version: 21.1.0
Browser: Firefox 111.0.1 + Chromium 111.0.5563.64

When an expanded article scrolls out of the visible area at the upper end, the headline sticks at 50 pixels below the upper end while the body scrolls underneath and is shown in the gap between the upper end and the headline.

grafik

The reason seems to be the version number in this style sheet definition

#app-content .compact .utils {
    [...]
    -webkit-position: sticky;
    position: sticky;
    top: 50px;
    [...]
}

#app-content.nc-major-version-25 .compact .utils {
    top: 0px;
}

as top: 0px is only defined for NC 25 but not NC 26.

Therefor it does not apply to the app-content div in NC 26:

<div id="app-content" 
  class="nc-major-version-26"
  data-nc-major-version="26"
  ng-class="{
    'loading-content': App.loading.isLoading('content') && !App.loading.isLoading('global'),
    'explore': App.isFirstRun(), 
  }"
  tabindex="-1"
  news-pull-to-refresh="showPullToRefresh">
Grotax pushed a commit that referenced this issue Apr 16, 2023
Signed-off-by: ManuelSailer <github.com@manuel-sailer.de>
Grotax added a commit that referenced this issue Apr 16, 2023
Changed
- Improve performance of item updates (#1322)

Fixed
- Fix display issue in NC26+ (#2192)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this issue Apr 16, 2023
Changed
- Improve performance of item updates (#1322)

Fixed
- Fix display issue in NC26+ (#2192)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant