Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 13 Blockers #253

Closed
4 of 5 tasks
BernhardPosselt opened this issue Jan 23, 2018 · 20 comments
Closed
4 of 5 tasks

Nextcloud 13 Blockers #253

BernhardPosselt opened this issue Jan 23, 2018 · 20 comments
Assignees

Comments

@BernhardPosselt
Copy link
Member

BernhardPosselt commented Jan 23, 2018

  • Navigation keys are broken due to position: relative on #app-content-wrapper
  • Compact mode is broken due to display: flex on #app-content-wrapper
  • Feed headlines have a text-decoration: underline due to added styles for a.external which conflict with our own rules
  • News content does not span the whole width anymore with position: static (see border bottom of earch article)
  • Unread count is hidden if feed title is long, e.g.:

This prevents a release on Nextcloud 13 and I've pulled 12.0.0 due to more issues surfacing recently which I won't be fixing due to #150

@BernhardPosselt BernhardPosselt changed the title Nextcloud 13 blockers Nextcloud 13 Blockers Jan 23, 2018
@skjnldsv skjnldsv self-assigned this Jan 23, 2018
@skjnldsv
Copy link
Member

  • Unread count is hidden if feed title is long, e.g.:
    Not on my stable13 server:
    kazam_screenshot_00000

@skjnldsv
Copy link
Member

@BernhardPosselt can you point me where the compact view is broken?
Also, should we support 13+ on the next release?

@BernhardPosselt
Copy link
Member Author

Hover over the settings area

compact

@BernhardPosselt
Copy link
Member Author

Unread count is hidden if feed title is long, e.g.:
Not on my stable13 server

Is not fixed, reopening

@BernhardPosselt
Copy link
Member Author

@skjnldsv add bemetal.org into a folder

@skjnldsv
Copy link
Member

capture d ecran_2018-01-28_16-06-40
@BernhardPosselt still good on my side... :/

@BernhardPosselt
Copy link
Member Author

@skjnldsv not the only one with this issue :) #234 (comment)

@BernhardPosselt
Copy link
Member Author

BernhardPosselt commented Jan 28, 2018

Also it seems to only affect Firefox, looks good in Chrome

@skjnldsv
Copy link
Member

Thanks, I'll try on ff :)

@MorrisJobke
Copy link
Member

Fixed in 13.0.0 RC 4

@onny
Copy link

onny commented Feb 2, 2018

Thanks for working on this issue.
Now I'm Nextcloud 13 RC4 and the latest git master of the news app, but the bug described here #234 (comment) is still present. Invisible feeds are still filling additional space in the list :(

@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2018

@onny what browser?

@onny
Copy link

onny commented Feb 2, 2018

Firefox and Chrome

@BernhardPosselt
Copy link
Member Author

Try clearing your browser cache

@skjnldsv
Copy link
Member

skjnldsv commented Feb 3, 2018

Yup, can't reproduce either :)

@onny
Copy link

onny commented Feb 3, 2018

That's how you can reproduce it using a Docker image with a fresh Nextcloud instance:

cd /tmp
wget "https://github.com/nextcloud/news/releases/download/12.0.1/news.tar.gz"
wget "https://onny.project-insanity.org/files/oc_news_db.tar.gz"
tar xvf news.tar.gz oc_news_db.tar.gz
docker build -t nextcloud-testing github.com/onny/docker-nextcloud
docker run -v /tmp/dockerdata:/data/data -v /tmp/news:/opt/nextcloud/apps/news -d --name nextcloud -p 80:80 nextcloud-testing
  • Visit http://localhost:80 and create admin account called "onny" and start a fresh Nextcloud instance
  • Enable app "News"

Import news app db backup:

cat /tmp/oc_news_{feeds,folders}.sql | sudo sqlite3 /tmp/dockerdata/owncloud.db

Now wait until Webcron will start loading the feeds. The hidden items will appear.

@onny
Copy link

onny commented Feb 8, 2018

Updated to Nextcloud 13.0 final and this issue is still present :(

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2018

@rullzer is the appdata clear function available for @onny ?

@rullzer
Copy link
Member

rullzer commented Feb 8, 2018

Not in 13 yet. But you can try https://github.com/rullzer/appdatacleaner

@onny
Copy link

onny commented Feb 13, 2018

So I cleaned up my feed directory and of course it solved the issue. It's not the best soloution but maybe the quickest ;) Thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants