Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken navigation keys in 13beta3 #239

Closed
janumix opened this issue Dec 14, 2017 · 7 comments
Closed

Broken navigation keys in 13beta3 #239

janumix opened this issue Dec 14, 2017 · 7 comments

Comments

@janumix
Copy link

janumix commented Dec 14, 2017

Explain the Problem

Navigation keys 'J' and 'K' (next, previous news) are broken. There are some keypress actions but hard to describe the order of articles application jumps to.

Steps to Reproduce

Just press 'J' on very top article in whatever folder.

System Information

  • News app version: 11.0.5
  • Nextcloud version: 13 best 3
  • PHP version: 17.1.9
  • Database and version: MySQL/MariaDB 10.0.31
  • Browser and version: Chrome 63.0.3239.84
  • Distribution and version:

Contents of nextcloud/data/nextcloud.log

Nothing related to application

@BernhardPosselt
Copy link
Member

Mark read on scroll is broken as well. I suppose its related to https://github.com/nextcloud/news/blob/master/js/directive/NewsScroll.js#L52 and https://github.com/nextcloud/news/blob/master/js/gui/KeyboardShortcuts.js which doesnt detect the proper distance anymore

@BernhardPosselt
Copy link
Member

A commit in server broke this, latest master works fine on my Nextcloud 12 install

@ChristophWurst @MorrisJobke @jancborchardt any idea?

@skjnldsv
Copy link
Member

@BernhardPosselt Check this commit: nextcloud/server#7431
Maybe it is?

@BernhardPosselt
Copy link
Member

@skjnldsv yes, works before that one

@jancborchardt
Copy link
Member

@skjnldsv do you have any idea what could fix it? :)

@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2018

Yeah, it's in my todo list :)

@skjnldsv skjnldsv self-assigned this Jan 11, 2018
@BernhardPosselt BernhardPosselt changed the title Broken navigation keys in 13beta3 Nextcloud 13 issues Jan 23, 2018
@BernhardPosselt BernhardPosselt changed the title Nextcloud 13 issues Broken navigation keys in 13beta3 Jan 23, 2018
@BernhardPosselt
Copy link
Member

Closed in favor of #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants