Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 13: Scrolling broken in News app #7643

Closed
BernhardPosselt opened this issue Dec 29, 2017 · 10 comments
Closed

Nextcloud 13: Scrolling broken in News app #7643

BernhardPosselt opened this issue Dec 29, 2017 · 10 comments

Comments

@BernhardPosselt
Copy link
Member

Latest master (ea858fc) on both server and News

See nextcloud/news#239 for more details

@rullzer rullzer added this to the Nextcloud 13 milestone Jan 2, 2018
@MorrisJobke MorrisJobke added the bug label Jan 2, 2018
@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@skjnldsv
Copy link
Member

skjnldsv commented Jan 3, 2018

Not really the place for this no?
We updated the guidelines based on the new app list, apps needs to update to match our requirements :)

@BernhardPosselt
Copy link
Member Author

@skjnldsv feel free to fix it in all apps ;)

@skjnldsv
Copy link
Member

skjnldsv commented Jan 3, 2018

@BernhardPosselt I did on most of them, but it's far from broken for everyone, I helped on calendar for the app navigation, contacts as a pr open end ready to merge. So far news is the only one we have that broke that hard (apparently, I did not test it) I'm already working on all apps after standardisation I have no time to fix all of them :/

@BernhardPosselt
Copy link
Member Author

position: relative on #app-content-wrapper is what broke things.

@LEDfan
Copy link
Member

LEDfan commented Jan 6, 2018

Removing the display: flex on #app-content-wrapper fixes the loading of new items for me (compact mode) . See nextcloud/news#245 (comment)

@jancborchardt
Copy link
Member

@LEDfan @BernhardPosselt a pull request to fix it, including testing with other apps like Contacts, Calendar, Mail, Notes etc is much appreciated. :)

@rullzer
Copy link
Member

rullzer commented Jan 11, 2018

Since this is apparently the new guidelines. And it is on the todo list of @skjnldsv . Let close this.

@rullzer rullzer closed this as completed Jan 11, 2018
@skjnldsv
Copy link
Member

@rullzer well, we can let it opened while we wait for my fix!

@rullzer rullzer reopened this Jan 11, 2018
@rullzer
Copy link
Member

rullzer commented Jan 11, 2018

ok fair enough just let me remove it from the 13 milestone then :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants