Fix updated api not returning any item after marking item as read

[Grotax]

The updated items api is supposed to return updated items, the last modified date is used for that.

I tried to use the $time provided through dependency injection but for some reason it is null.

I don't really care if we can't use dep injection there, if I made a mistake though I would be happy to adjust it.

[Grotax]

seems like bats is broken, sometimes ${BATS_SUITE_TEST_NUMBER} is empty

[Grotax]

I don't know how to fix the test, I guess you need to mock the time object to return a fixed value but I don't know how.

[anoymouserver]

Maybe like this? (only getMicroTime() instead)

news/tests/Unit/Service/FeedServiceTest.php

Lines 100 to 107 in 2baee21

	$this->time = 222;
	$this->autoPurgeMinimumInterval = 10;
	$timeFactory = $this->getMockBuilder(Time::class)
	->disableOriginalConstructor()
	->getMock();
	$timeFactory->expects($this->any())
	->method('getTime')
	->will($this->returnValue($this->time));

(I didn't look at the test though, just saw your question.)

[Grotax]

Well I managed to make the test working, it just checks if the parameter is given but not the value.
Which is maybe also not so important. I tried to make the time a fixed value by creating a Mock similar to the db object.
And then tired to replace the return value of the method that is used but in the test result the value did not match.

[Grotax]

@anoymouserver thanks :)

I guess like it is done now also works. No need to test the function with a specific time.
And my new api tests actually test if this works the way it is expected at api level. :)

[Grotax]

I'm basically done with this, it fixes this specific error.
To fully fix the API the date would need to be updated whenever an item is changed in some way.

Any opinions?
Also related to #1727

[Grotax]

rebased on master

[Grotax]

If there is no negative feedback I would just squash the commits and merge it.