Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If items of feed do not provide an author fallback to feed author #1803

Merged
merged 2 commits into from
May 31, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented May 31, 2022

Some feeds do not have authors for each item but instead provide only an author for the feed.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax changed the title If items of feed do not provide an author fallback to feed author. If items of feed do not provide an author fallback to feed author May 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #1803 (5822490) into master (fca05d5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1803      +/-   ##
============================================
+ Coverage     91.62%   91.66%   +0.03%     
- Complexity      778      781       +3     
============================================
  Files            65       65              
  Lines          2724     2747      +23     
============================================
+ Hits           2496     2518      +22     
- Misses          228      229       +1     
Impacted Files Coverage Δ
lib/Db/Item.php 100.00% <100.00%> (ø)
lib/Fetcher/FeedFetcher.php 80.89% <100.00%> (+1.16%) ⬆️
lib/Command/ExploreGenerator.php 100.00% <0.00%> (ø)
lib/Explore/RecommendedSites.php 0.00% <0.00%> (ø)
lib/Controller/FeedController.php 100.00% <0.00%> (ø)
lib/Controller/PageController.php 100.00% <0.00%> (ø)
lib/Fetcher/Client/FeedIoClient.php 100.00% <0.00%> (ø)
lib/Controller/FeedApiController.php 100.00% <0.00%> (ø)
lib/Db/Feed.php 99.05% <0.00%> (+<0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb6419...5822490. Read the comment docs.

@Grotax Grotax merged commit 1c91928 into master May 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the feed/fallbackauthor branch May 31, 2022 13:46
Grotax added a commit that referenced this pull request May 31, 2022
Changed
-  If items of feed do not provide an author fallback to feed author (#1803)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request May 31, 2022
Grotax added a commit that referenced this pull request May 31, 2022
Changed
-  If items of feed do not provide an author fallback to feed author (#1803)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants