Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding feed that was just deleted is causing an error #1872

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Aug 19, 2022

No description provided.

@Grotax Grotax force-pushed the fix/FeedController branch 2 times, most recently from e2309ed to 5bccac5 Compare August 19, 2022 10:00
@codecov-commenter
Copy link

Codecov Report

Merging #1872 (77c2f02) into master (fca05d5) will decrease coverage by 0.16%.
The diff coverage is 87.50%.

❗ Current head 77c2f02 differs from pull request most recent head 5bccac5. Consider uploading reports for the commit 5bccac5 to get more accurate results

@@             Coverage Diff              @@
##             master    #1872      +/-   ##
============================================
- Coverage     91.62%   91.46%   -0.17%     
- Complexity      778      793      +15     
============================================
  Files            65       65              
  Lines          2724     2777      +53     
============================================
+ Hits           2496     2540      +44     
- Misses          228      237       +9     
Impacted Files Coverage Δ
lib/Cron/UpdaterJob.php 0.00% <0.00%> (ø)
lib/Db/ItemMapperV2.php 98.51% <60.00%> (-1.49%) ⬇️
lib/Service/FeedServiceV2.php 97.80% <81.81%> (-2.20%) ⬇️
lib/Fetcher/FeedFetcher.php 80.62% <95.00%> (+0.89%) ⬆️
lib/Controller/FeedController.php 100.00% <100.00%> (ø)
lib/Db/Item.php 100.00% <100.00%> (ø)
lib/Db/NewsMapperV2.php 100.00% <100.00%> (ø)
lib/Utility/OPMLExporter.php 100.00% <100.00%> (ø)
lib/Command/ExploreGenerator.php 100.00% <0.00%> (ø)
lib/Explore/RecommendedSites.php 0.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Grotax Grotax marked this pull request as ready for review August 19, 2022 11:10
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax force-pushed the fix/FeedController branch from 5bccac5 to 2eb2629 Compare August 25, 2022 05:47
@Grotax
Copy link
Member Author

Grotax commented Aug 25, 2022

rebased to solve merge conflict

@Grotax Grotax merged commit c217448 into master Aug 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/FeedController branch August 25, 2022 05:50
Grotax added a commit that referenced this pull request Aug 30, 2022
Changed
- Ported the admin settings to vue (#2353)

Fixed
- Fix PHP 8.1 deprecations (#1861)
- Document api item types (#1861)
- Fix deprecation warnings from Nextcloud server (#1869)
- Fix when marking all items as read, all items of the user are used in the sql query (#1873)
- Fix adding feed via the web-ui that was just deleted causing an error (#1872)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Aug 30, 2022
Grotax added a commit that referenced this pull request Aug 30, 2022
Changed
- Ported the admin settings to vue (#2353)

Fixed
- Fix PHP 8.1 deprecations (#1861)
- Document api item types (#1861)
- Fix deprecation warnings from Nextcloud server (#1869)
- Fix when marking all items as read, all items of the user are used in the sql query (#1873)
- Fix adding feed via the web-ui that was just deleted causing an error (#1872)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants