Fix keyboard navigation + cron job notification #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyst
force-pushed
the
fix-keyboard-navigation
branch
from
d63ac2c
to
45ea2c7
Compare
Grotax
requested changes
Oct 23, 2022
There was a problem hiding this comment.
during build gulp fails
> node node_modules/gulp-cli/bin/gulp.js
[07:32:26] Using gulpfile /workspaces/news/js/gulpfile.js
[07:32:26] Starting 'default'...
[07:32:26] Starting 'lint'...
gui/KeyboardShortcuts.js: line 234, col 38, 'scrollArea' is defined but never used.
1 error
[07:32:27] 'lint' errored after 559 ms
[07:32:27] Error in plugin "gulp-jshint"
Message:
JSHint failed for: gui/KeyboardShortcuts.js
Details:
domainEmitter: [object Object]
domainThrown: false
[07:32:27] 'default' errored after 562 ms
make[1]: *** [Makefile:88: npm] Error 1
make[1]: Leaving directory '/workspaces/news'
make: *** [Makefile:69: build] Error 2
45ea2c7
to
f860ea3
Compare
|
Oops, should be fixed now. The effect of removing a |
SMillerDev
approved these changes
Oct 23, 2022
Signed-off-by: Rhys Tyers <mail@rhy.si>
Signed-off-by: Rhys Tyers <mail@rhy.si>
rhyst
force-pushed
the
fix-keyboard-navigation
branch
from
f860ea3
to
69b441e
Compare
|
Sorry I managed to completely mess up that rebase so most of my changes weren't in. Pushed again, will just confirm this still does what I think it does. |
|
I think its good 😬 |
Grotax
approved these changes
Oct 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard navigation through items was not working correctly in NC25 and highlighting active item on scroll was not working in NC25, NC24, NC23 (I think) so I have attempted to fix this.
The cronjob warning notification layout was messed up on NC25 as well so also attempted a quick fix for that.
Also tidied up the version number stuff a bit. I feel like the Nextcloud JS globals (the
window.OCobject) should have that info but I couldn't find it anywhere 🤷. Dumping the version number from PHP into a data attribute feels wrong 🤠