Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Add Jest for Unit tests #1968

Merged
merged 12 commits into from
Nov 2, 2022

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Oct 27, 2022

Follows #1922

Adding Unit Test Framework to Vue Rewrite

  • Add Jest Framework and Cleanup Other/Older Unit Test Frameworks (Jasmine/Sinon/Karma)
  • Update ESLint, StyleLint, Babel and Typescript Configs for Jest
  • Update to @nextcloud/vue v7 so we can avoid conflicts with component names (adds Nc.. prefix to nextcloud vue components)
  • Add some basic tests for Existing Components (may want to do more here)

How to Run

npm run test to run all spec file suites

Testing Completed

  • Verified that App Builds with npm run build
  • Verified app builds with make
  • Verified that App loads on localhost (NC 23)
  • Verified that Tests all pass

(I would upload screenshots but GitHub is not allowing me to at this moment - remind me tomorrow and I will try again)

Up Next

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@devlinjunker
Copy link
Contributor Author

can we add skip-changelog label to this PR?

@SMillerDev
Copy link
Contributor

No, it should have a changelog entry for the updated components at the very least.

@Grotax
Copy link
Member

Grotax commented Oct 27, 2022

the branch could also use a rebase on master, we fixed the integration tests there already.

@devlinjunker
Copy link
Contributor Author

devlinjunker commented Oct 27, 2022

@SMillerDev hmm okay, I can add a change log entry although I think it’s kinda silly for these smaller PRs to have to always add one explaining the changes but then when we finally merge to master we’ll have to fix the CHANGELOG so it makes sense

@Grotax i will look into creating a branch that upmerges all master branch changes to the vue-rewrite branch (to make sure integration tests work and to get aligned with the admin vue page changes)

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Copy link
Member

@Grotax Grotax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

tsconfig.json Outdated Show resolved Hide resolved
@Grotax
Copy link
Member

Grotax commented Nov 2, 2022

Thanks @devlinjunker 🥳

@Grotax Grotax merged commit 760c442 into nextcloud:vue-rewrite Nov 2, 2022
@Grotax Grotax mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants