-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue Rewrite] Add Jest for Unit tests #1968
Conversation
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
can we add |
No, it should have a changelog entry for the updated components at the very least. |
the branch could also use a rebase on master, we fixed the integration tests there already. |
@SMillerDev hmm okay, I can add a change log entry although I think it’s kinda silly for these smaller PRs to have to always add one explaining the changes but then when we finally merge to master we’ll have to fix the CHANGELOG so it makes sense @Grotax i will look into creating a branch that upmerges all master branch changes to the |
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me
Thanks @devlinjunker 🥳 |
Follows #1922
Adding Unit Test Framework to Vue Rewrite
Nc..
prefix to nextcloud vue components)How to Run
npm run test
to run all spec file suitesTesting Completed
npm run build
make
(I would upload screenshots but GitHub is not allowing me to at this moment - remind me tomorrow and I will try again)
Up Next