Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowEvalScript set to true #2262

Merged
merged 1 commit into from
Jun 18, 2023
Merged

allowEvalScript set to true #2262

merged 1 commit into from
Jun 18, 2023

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Jun 17, 2023

  • Resolves: Nothing

Summary

related to #2242

Removes the error message of the browser but buttons still don't work.

Checklist

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Copy link
Member Author

Grotax commented Jun 17, 2023

Thing is this is already a deprecated function...

   96     Call to deprecated method allowEvalScript() of class               
         OCP\AppFramework\Http\EmptyContentSecurityPolicy:                  
         Eval should not be used anymore. Please update your scripts. This  
         function will stop functioning in a future version of Nextcloud.   

@Grotax
Copy link
Member Author

Grotax commented Jun 17, 2023

We really need a new frontend or become a backend/api only app, which would be fine for my usecase but not for many others...

@SMillerDev
Copy link
Contributor

Let's release a beta with this and then maybe just drop the frontend?

@Grotax Grotax merged commit 9b29d84 into master Jun 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the allowEvalScript branch June 18, 2023 12:41
Grotax added a commit that referenced this pull request Jun 18, 2023
Changed
-  allowEvalScript set to true (#2262)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Jun 18, 2023
Grotax added a commit that referenced this pull request Jun 19, 2023
Changed
-  allowEvalScript set to true (#2262)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants