Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Fetch Item Bugfix + other cleanup #2343

Merged
merged 3 commits into from
Sep 3, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Sep 1, 2023

Related to #748

Follows #2339

🗒️ Summary

Fixed Bug in retrieving items from backend

  • Was due to using the end of the items array in the route components as the offset parameter to the backend
  • Stored reference to the last id number retrieved when making backend feed item calls, and use this for offset parameter instead

Moved all FeedItem... components into feed-display/ directory

Moved all backend calls to ...service.ts files in dataservices/ directory

  • Added basic unit tests for these

✅ Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
    - [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

📷 Visual

All Items loading:
bugfix

➡️ Up Next

  • Reuse VirtualScroll component for:
    • display items in a folder
    • display all items in database
  • Sidebar Actions (WIP)
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay
  • Quick access to Settings
  • Update Documentation
  • Mobile friendly layout
  • Warning and Error Messages
  • Audio/Video Feeds

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@Grotax Grotax merged commit e2e8ae5 into nextcloud:vue-rewrite Sep 3, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants