[Vue Rewrite] BugFix (Feed Actions) + Warning Message + subscribe_to URL parameter

[devlinjunker]

Related to #748

Follows #2354

🗒️ Summary

• Fix Sidebar Feed Actions Menu (broken from rebase)
• add warning message generated with PHP
• check for subcribe_to parameter in sidebar to open popover and in popover to pre-populate input

✅ Checklist

• Code is properly formatted
• Sign-off message is added to all commits

- [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

📷 Visual

Feed Actions Menu:

Warning Message:

subscribe_to URL Param:

➡️ Up Next

MVP:

• Share Menu
• Audio/Video Feed Items
• Mobile friendly layout (since we are no longer displaying the feed item below the row)
• Update Documentation for Front End
  • Developer Tips/Organization
  • Remove Frontend/JS Plugin Documentation
  • Front End Unit Tests
• Settings in Sidebar
  • Keyboard Navigation
  • Mark on Scroll
  • Reverse Order (Oldest to Newest)
  • Upload/Download Subscriptions/Articles
• Error Messages (on backend request failure)
• Fix Explore Page

Following Rewrite Release Improvements:

• addArticleAction Plugin API
• use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
• Additional Views (Compact/Expanded etc)

[Grotax]

Hmm the frontend test failed, did you check why?

[devlinjunker]

@Grotax oh yeah. I can fix that quickly today. Just because it’s checking for the subscribe_to url param in the test but I didn’t set up any mocks for it.

For the static analysis failure, are you going to create a PR against the master branch to fix that? If so, I can do an upmerge to fix that once you do

[Grotax]

I didn't check in detail but based on the error message and since we don't have that on master I think it comes from the comment you added in that php file.

I can check before I merge this should be easy to fix

[devlinjunker]

@Grotax I'm not sure it comes from the comment, I see this in the logs of the failing job:

 ------ --------------------------------------------------------------- 
  Line   Db/ItemMapperV2.php                                            
 ------ --------------------------------------------------------------- 
  204    Fetching class constant ASSOCIATIVE of deprecated class        
         Doctrine\DBAL\FetchMode:                                       
         Use the dedicated fetch*() methods for the desired fetch mode  
         instead.                                                       
  230    Fetching class constant COLUMN of deprecated class             
         Doctrine\DBAL\FetchMode:                                       
         Use the dedicated fetch*() methods for the desired fetch mode  
         instead. 

I think this has to do with the dependabot update that was recently merged: #2362

I also see the error in the release cut PR: #2359

[Grotax]

Ah now I see, yea I'm not sure if we can change the code.
dbal is actually just a dev dependency when installed we use the version of the server.
And they use an older version https://github.com/nextcloud/3rdparty/blob/master/composer.json

But the phpcs complains in this PR could be fixed.

[devlinjunker]

ah, I see, I'll clean up that phpcs failure today

[Grotax]

Tested and works after clean rebuild of my dev environment, thanks :)