Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Audio/Video playback from enclosures in FeedItem #2366

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

devlinjunker
Copy link
Contributor

Related to #748

Follows #2361

🗒️ Summary

  • Add Audio/Video Feed Item Playback
    • Play Audio at bottom of App, so you can still scroll articles
    • Play Video inline of FeedItem (unable to continue reading articles)
    • Playing Audio pauses video, playing video pauses audio

✅ Checklist

- [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

📷 Visual

Audio:
Screenshot 2023-09-28 at 2 36 15 PM

Video:
Screenshot 2023-09-28 at 2 39 40 PM

Pause other audio/video on play:
pause

➡️ Up Next

  • Fix Explore Page
  • Error Messages (on backend request failure)
  • Mobile friendly layout (since we are no longer displaying the feed item below the row)
  • Settings in Sidebar
    • Keyboard Navigation
    • Mark on Scroll
    • Reverse Order (Oldest to Newest)
    • Upload/Download Subscriptions/Articles
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
    • Also need to update search provider php code
  • Update Documentation for Front End
    • Developer
      • Frontend Tips/Organization
      • Front End Unit Tests
    • Sharing
    • Remove Frontend/JS Plugin Documentation
  • addArticleAction Plugin API
    • Nextcloud News Code
    • Add to Bookmarks Example Plugin
    • Add New Frontend/JS Plugin Documentation

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@devlinjunker devlinjunker changed the title tested with audio and video feeds [Vue Rewrite] Audio/Video enclosures in FeedItem Sep 28, 2023
@devlinjunker devlinjunker changed the title [Vue Rewrite] Audio/Video enclosures in FeedItem [Vue Rewrite] Audio/Video playback from enclosures in FeedItem Sep 28, 2023
@devlinjunker devlinjunker mentioned this pull request Oct 2, 2023
8 tasks
@devlinjunker devlinjunker added the Skip-Changelog No changelog update is required, minor change label Oct 4, 2023
@devlinjunker
Copy link
Contributor Author

if there are no issues with this PR, I will merge it in soon

@Grotax
Copy link
Member

Grotax commented Oct 5, 2023

Works for me :)

@Grotax Grotax merged commit b6a4293 into nextcloud:vue-rewrite Oct 5, 2023
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants