Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Explore Page styles and behavior #2376

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

devlinjunker
Copy link
Contributor

Related to #748

🗒️ Summary

  • Copy styles from old explore.scss file to Vue File
  • Use flex to make grid more responsive
  • Clicking subscribe button opens AddFeed popover with url pre-populated from feeds.en.json request data

✅ Checklist

- [ ] Changelog entry added for all important changes.

📷 Visual

Using FlexGrid CSS
Screenshot 2023-10-10 at 2 08 02 PM
Screenshot 2023-10-10 at 2 08 15 PM
Screenshot 2023-10-10 at 2 08 21 PM

Clicking Subscribe Button
explore

➡️ Up Next

  • Update Documentation for Front End
    • Developer
      • Frontend Tips/Organization
      • Front End Unit Tests
    • Sharing
    • Remove Frontend/JS Plugin Documentation ( should we just update this when we add the new addArticleAction Plugin API?)
  • Settings in Sidebar
    • Component
    • Backend Requests + Application Behavior Changes
      • Keyboard Navigation
      • Mark on Scroll
      • Reverse Order (Oldest to Newest)
      • Upload/Download Subscriptions/Articles
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
    • Also need to update search provider php code
    • Update Documentation?
  • addArticleAction Plugin API
    • Nextcloud News Code
    • Add to Bookmarks Example Plugin
    • Add New Frontend/JS Plugin Documentation

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@devlinjunker devlinjunker added the Skip-Changelog No changelog update is required, minor change label Oct 10, 2023
@Grotax Grotax merged commit 30e4e9b into nextcloud:vue-rewrite Oct 11, 2023
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants