Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Fix css issues and start updating docs #2381

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Oct 16, 2023

Related to #748

💡 Tips for Reviewer:

🗒️ Summary

  • Fixes issue described in [Vue Rewrite] Basic Mobile accessible interface #2371 and discussed here
    • use #content for Vue selector
    • use Vue Application app.error popover to display cron warning
    • Add links array to error object that can display help links in the error/warning message
  • Fixes Explore Page CSS
  • Start updating the Doc pages (Frontend Plugin section is TODO until we rewrite that...)

✅ Checklist

- [ ] Changelog entry added for all important changes.

📷 Visual

Cron Warning:
Screenshot 2023-10-16 at 1 30 05 PM

Using Placeholder Color for viewed Items:
Screenshot 2023-10-16 at 1 30 11 PM

Screenshot 2023-10-16 at 1 29 03 PM





Explore Page:
Screenshot 2023-10-16 at 1 28 47 PM

➡️ Up Next

  • Settings in Sidebar (@scottdotau I think I'll start on this soon unless you're making progress - I'll try to start by looking into the backend requests + application behavior before the component..)
    • Component
    • Backend Requests + Application Behavior Changes
      • Keyboard Navigation
      • Mark on Scroll
      • Reverse Order (Oldest to Newest)
      • Upload/Download Subscriptions/Articles

@Grotax I think both of these can be done after a beta release:

  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
    • Also need to update search provider php code
    • Update Documentation?
  • addArticleAction Plugin API
    • Nextcloud News Code
    • Add to Bookmarks Example Plugin
    • Add New Frontend/JS Plugin Documentation

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@devlinjunker devlinjunker added the Skip-Changelog No changelog update is required, minor change label Oct 16, 2023
…an be committed

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@Grotax
Copy link
Member

Grotax commented Oct 18, 2023

Hey, looks good :)

The gap is gone and the UI works for me.

Regarding your other points I agree with that :)

@Grotax Grotax merged commit 94f04d4 into nextcloud:vue-rewrite Oct 19, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants