fix: adopt search to NC 28 filters #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
fix/search/nc28
branch
from
e1cbe1d
to
b03d979
Compare
anoymouserver
approved these changes
Nov 14, 2023
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
fix/search/nc28
branch
from
b03d979
to
412ce77
Compare
|
Is it possible this did not work? We still see deprecation warnings. Is it maybe calling the same method in the end? |
|
I think the deprecation warning is still thrown because the method still exists in the code, but we can't get rid of it yet. Not sure how to resolve that really other than dropping support pre-28. |
Grotax
added a commit
that referenced
this pull request
Nov 20, 2023
Fixed - Fix search support for Nextcloud 28 (#2432) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjusts search to use filters rather than terms, fixing the phpstan check
Checklist