Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenreader fixes #2946

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Screenreader fixes #2946

merged 4 commits into from
Nov 29, 2024

Conversation

wofferl
Copy link
Collaborator

@wofferl wofferl commented Nov 28, 2024

Summary

This PR adds fixes for screen readers

  • add landmarks for the content list and details
  • make article list recognized by screen readers
  • item can be selected by screen readers during heading navigation

Checklist

@wofferl wofferl marked this pull request as ready for review November 28, 2024 21:32
…ed by screen readers

Signed-off-by: Wolfgang <github@linux-dude.de>
…ecognised by screen readers

Signed-off-by: Wolfgang <github@linux-dude.de>
…he current item

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl force-pushed the screenreader_fixes branch 2 times, most recently from 8dde5c0 to f540129 Compare November 28, 2024 21:58
… they are in the dynamic list

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl merged commit c973920 into nextcloud:master Nov 29, 2024
23 of 24 checks passed
Grotax added a commit that referenced this pull request Dec 1, 2024
Changed
- add region role to content list and details so that it can be used by screen readers (#2946)
- split display settings in "display mode" and "split mode" to allow combining modes (#2950)
- add display mode optimized for screen readers (#2950)

Fixed
- use appropriate semantic HTML elements for the item list to be recognised by screen readers (#2946)
- make title in item list clickable for screen readers to select the current item (#2946)
- remove mime type check when importing `opml`, they are not reliable anyway (#2951)
- Embedded images are all scaled to max (#2945)
- If an article doesn't have title, there's no link to the article (#758)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Dec 1, 2024
Grotax added a commit that referenced this pull request Dec 1, 2024
Changed
- add region role to content list and details so that it can be used by screen readers (#2946)
- split display settings in "display mode" and "split mode" to allow combining modes (#2950)
- add display mode optimized for screen readers (#2950)

Fixed
- use appropriate semantic HTML elements for the item list to be recognised by screen readers (#2946)
- make title in item list clickable for screen readers to select the current item (#2946)
- remove mime type check when importing `opml`, they are not reliable anyway (#2951)
- Embedded images are all scaled to max (#2945)
- If an article doesn't have title, there's no link to the article (#758)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@wofferl wofferl deleted the screenreader_fixes branch December 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in item content not clickablee
2 participants