Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish french translation for the about view #18

Merged
merged 2 commits into from
May 1, 2017

Conversation

tbille
Copy link
Contributor

@tbille tbille commented Apr 18, 2017

Licence: AGPL3+ or any other compatible license

Description

Finish french translation for the about view

Screenshots or screencasts

a propos de l extension nextcloud pour filelink_004

@oparoz oparoz self-requested a review April 18, 2017 21:31
@oparoz oparoz added this to the v1.6 milestone Apr 18, 2017
@oparoz
Copy link
Member

oparoz commented Apr 18, 2017

👍
Thank you @tbille. Looks good. I just need to test it to see if it's accepted by Thunderbird as I've had issues in the past with some strings in the XML :)

@tbille
Copy link
Contributor Author

tbille commented Apr 18, 2017

okay, I forgot to translate the install.rdf I'll do it in another pull-request :)

@oparoz
Copy link
Member

oparoz commented Apr 18, 2017

You can simply add another commit to this one, unless it's because of a technical issue on your side?

@tbille
Copy link
Contributor Author

tbille commented Apr 18, 2017

Finally I added it here, it was simply to keep the sense of the description of the pull request.

@oparoz
Copy link
Member

oparoz commented Apr 18, 2017

Finally I added it here, it was simply to keep the sense of the description of the pull request.

Yeah, I understand, but I think it's OK this time :)

@guillaumev guillaumev merged commit 45b1cbd into nextcloud:master May 1, 2017
@tbille tbille deleted the finish-french-translation branch May 1, 2017 14:47
joendres added a commit to joendres/nextcloud-filelink that referenced this pull request Jan 22, 2020
…th' into 'master'

Resolve "Upload error for nextcloud accounts with external auth"

Closes nextcloud#18

See merge request joendres/filelink-nextcloud!12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants