-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppNavigationItem improved editing mode and AppNavigationNewItem component #1277
Conversation
Context: This is for the "New folder" functionality. There the entry should inline switch to become an autofocused input field where you can put in the folder name. We also need the same for Mail for the action menu where we currently directly show an input field for folder creation, which could be more elegant. cc @ChristophWurst @GretaD |
I'm just curious.. Do you mean something like this: |
Not really. There are no options like checkboxes. Its not expanding and just one text input |
33fd7be
to
cb567f6
Compare
The behaviour we want works now. I will rename some variables to make the code more understandable, but then its done. |
@jancborchardt Should we force the icon to be a "+" in new Item mode or should the developer choose that ? |
229583e
to
c1a4e1d
Compare
@jancborchardt You said in the Talk group the text should never move (in editing or add item mode). I have implemented that in add item mode and will also implement that in the editing mode. |
(editing mode is currently broken here, but i will fix that) |
done
done |
@jancborchardt Have you decided yet ? |
Hey! Sorry, Jan is in (well deserved) vacations now :( |
done |
9e012ad
to
9181384
Compare
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
…m input box Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
Signed-off-by: TessyPowder <tessy.powder@gmail.com>
@JonathanTreffler could you rebase and swuash the commits please? 45 is quite a lot! |
Let's try to get this in everyone. Or else it'll stay idle for too long |
Looks good, docs are 👌 |
Ah, I thought you did already. |
Sorry if this is the wrong place to post this, but I cannot import the |
@powerpaul17 what components version are you using? |
AH, it was forgotten in the exports |
Sorry. I was pretty busy lately. |
The latest release: 3.3.1
That's what I thought. I would have created a fix myself but I'm not familiar with the repo structure. |
@jancborchardt and I decided to create a new mode for the AppNavigationItem, to add something similar to the editable mode, but without the editing part, just a inline input box that apperas when the logo is clicked and a event when the new input gets acccepted.
We will need this for the News App Vue Rewrite.
I think @jancborchardt can explain this much better than me.
Screenshots
when clicked: