Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu font for apps #1543

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix menu font for apps #1543

merged 2 commits into from
Nov 5, 2020

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 4, 2020

This fixes it for mail

before
accountmenub
after
accountmenu
before
threadmenub
after
threadmenu
before
mailboxmenub
After
mailboxmenu

Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD marked this pull request as draft November 4, 2020 19:54
@GretaD
Copy link
Contributor Author

GretaD commented Nov 4, 2020

this to be merged after this #1542

@GretaD GretaD marked this pull request as ready for review November 4, 2020 19:57
@GretaD GretaD self-assigned this Nov 4, 2020
@GretaD GretaD added 3. to review Waiting for reviews bug Something isn't working labels Nov 4, 2020
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been bothering me for months! ^^'
Yes pleeaaaase ! 🚀 😍

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

/backport to stable2

@PVince81
Copy link
Contributor

PVince81 commented Nov 5, 2020

doesn't seem to fix nextcloud/spreed#4330, so the problem for the latter might be elsewhere

@PVince81
Copy link
Contributor

PVince81 commented Nov 5, 2020

not sure why the action buttons in the talk menu would behave differently, it seems that the font size of the "button" is stronger than the one of the "span" that's inside.

I had to move the font-size from the &__text to the parent element to make it work:

diff --git a/src/assets/action.scss b/src/assets/action.scss
index 0f5d5e0..6a03eaf 100644
--- a/src/assets/action.scss
+++ b/src/assets/action.scss
@@ -65,6 +65,7 @@
                background-color: transparent;
                box-shadow: none;
 
+               font-size: var(--default-font-size);
                font-weight: normal;
                line-height: $clickable-area;
 
@@ -107,10 +108,6 @@
 
                &__title {
                        font-weight: bold;
-                       font-size: var(--default-font-size);
-               }
-               &__text {
-                       font-size: var(--default-font-size);
                }
        }
 }

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

not sure why the action buttons in the talk menu would behave differently, it seems that the font size of the "button" is stronger than the one of the "span" that's inside.

Maybe this and inherit in the title/text elements?

@PVince81
Copy link
Contributor

PVince81 commented Nov 5, 2020

with the above diff on top of the PR it works for me.

if it also works for mail then we could go with that ?

Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD changed the title Fix/menu font mail Fix menu font for apps Nov 5, 2020
@GretaD GretaD requested a review from PVince81 November 5, 2020 10:22
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good now also for the Talk menu, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants