Add aria-description to AppNavigationItem #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
raimund-schluessler,
GretaD and
skjnldsv
raimund-schluessler
approved these changes
Mar 14, 2022
JuliaKirschenheuter
added
3. to review
skjnldsv
approved these changes
Mar 15, 2022
skjnldsv
previously requested changes
Mar 15, 2022
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
enhancement/3955-add-aria-details-to-app-navigation-item
branch
from
839c811
to
8aea13a
Compare
ChristophWurst
approved these changes
Mar 21, 2022
ChristophWurst
deleted the
enhancement/3955-add-aria-details-to-app-navigation-item
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for nextcloud/calendar#3955
used for nextcloud/calendar#4045
Documentation for "aria-description": https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-description