Remove Action from CheckboxBlankCircle and add more description text

[JuliaKirschenheuter]

fixes #3955

• Requires Add aria-description to AppNavigationItem nextcloud-libraries/nextcloud-vue#2548

[codecov]

Codecov Report

Merging #4045 (6746ddc) into main (e6b4f9f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6746ddc differs from pull request most recent head f1686f2. Consider uploading reports for the commit f1686f2 to get more accurate results

@@             Coverage Diff              @@
##               main    #4045      +/-   ##
============================================
- Coverage     29.39%   29.36%   -0.04%     
  Complexity      330      330              
============================================
  Files           221      221              
  Lines          7712     7721       +9     
  Branches       1022     1026       +4     
============================================
  Hits           2267     2267              
- Misses         5445     5454       +9     

Flag	Coverage Δ
javascript	20.47% <0.00%> (-0.03%)	⬇️
php	68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ts/AppNavigation/CalendarList/CalendarListItem.vue	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b4f9f...f1686f2. Read the comment docs.

[raimund-schluessler]

I have to admit, I don't really understand why this shouldn't be an Action, but this anyway needs changes to work. Please see my comments.

[raimund-schluessler]

Looks good code wise.

[JuliaKirschenheuter]

I have to admit, I don't really understand why this shouldn't be an Action, but this anyway needs changes to work. Please see my comments.

After review with @jancborchardt we have decided not to to have a same action on two different components: AppNavigationItem and CheckboxBlankCircle. User click on AppNavigationItem -> toggle will be triggered, and it is enough.

[ChristophWurst]

👍 otherwise

[ChristophWurst]

Marking as draft to prevent an accidental merge before main ships @nextcloud/vue with nextcloud-libraries/nextcloud-vue#2548.

[JuliaKirschenheuter]

Marking as draft to prevent an accidental merge before main ships @nextcloud/vue with nextcloud/nextcloud-vue#2548.

i think we can merge it: https://github.com/nextcloud/nextcloud-vue/releases/tag/v4.4.0

[ChristophWurst]

i think we can merge it: https://github.com/nextcloud/nextcloud-vue/releases/tag/v4.4.0

It doesn't mention nextcloud-libraries/nextcloud-vue#2548.

nextcloud-libraries/nextcloud-vue#2548 was released with https://github.com/nextcloud/nextcloud-vue/releases/tag/v5.2.0 and pulled into this repo with #4147.

So this is unblocked.