Add icon slot to AppNavigationNew component #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
2. developing
raimund-schluessler
force-pushed
the
fix/2707/appnavigationnew-icon
branch
from
54ac41e
to
9736800
Compare
raimund-schluessler
requested review from
marcoambrosini,
Pytal,
skjnldsv,
korelstar,
st3iny,
dartcafe and
GretaD
raimund-schluessler
added
3. to review
raimund-schluessler
force-pushed
the
fix/2707/appnavigationnew-icon
branch
from
9736800
to
d97a134
Compare
Pytal
approved these changes
Jun 2, 2022
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/2707/appnavigationnew-icon
branch
from
d97a134
to
06a0504
Compare
marcoambrosini
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the simple button element in the
AppNavigationNewcomponent with theButtoncomponent and exposes an icon slot to add a material design icon. I also added a documentation example.Implements part of #2707.