Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components missing an icon slot #2707

Closed
1 of 2 tasks
Tracked by #32072
st3iny opened this issue May 24, 2022 · 3 comments · Fixed by #2722
Closed
1 of 2 tasks
Tracked by #32072

Components missing an icon slot #2707

st3iny opened this issue May 24, 2022 · 3 comments · Fixed by #2722
Labels
2. developing Work in progress high High priority regression Regression of a previous working feature
Milestone
6.0.0

Comments

@st3iny
Copy link
Contributor

st3iny commented May 24, 2022 •
edited
Loading

Due to the deprecation/removal of the scss cacher we need icon slots for very component here. Otherwise, some components are not really usable anymore.

Ref nextcloud/server#32072

(Incomplete) list of components that still need an icon slot
@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of high High priority regression Regression of a previous working feature labels May 24, 2022
@st3iny
Copy link
Contributor Author

st3iny commented May 24, 2022

Please let me know if there is another way to embed a material icon into those components.

@st3iny st3iny mentioned this issue May 24, 2022
Closed
46 tasks
@raimund-schluessler
Copy link
Contributor

Please let me know if there is another way to embed a material icon into those components.

I don't think there is another way. AppNavigationNew should just use the Button component and expose its icon slot.

@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone May 26, 2022
@dartcafe
Copy link
Contributor

I added the Avatar component

This was referenced Jun 2, 2022
Merged
Merged
@raimund-schluessler raimund-schluessler added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add md icon slot to Avatar component nextcloud-libraries/nextcloud-vue
3 participants
@st3iny @raimund-schluessler @dartcafe