Add md icon slot to Avatar component #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
feature/2707/avatar-icon
branch
from
92c252f
to
cc8c199
Compare
raimund-schluessler
force-pushed
the
feature/2707/avatar-icon
branch
from
490f942
to
94ac4ad
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
feature/2707/avatar-icon
branch
from
94ac4ad
to
1f4d2fb
Compare
raimund-schluessler
requested review from
jancborchardt,
skjnldsv,
st3iny,
dartcafe,
marcoambrosini and
GretaD
raimund-schluessler
added
3. to review
GretaD
approved these changes
Jun 13, 2022
|
@raimund-schluessler just a small thing about the example: On a blue button, the icons/text should be white for proper contrast, so probably good to reflect it in the example there? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a material design icon slot to the avatar component. Implements the second part of and closes #2707.
I also added an example for an avatar with a md icon.